Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NME] Warning for protected block names pops while still typing #12715

Closed
PatrickRyanMS opened this issue Jul 7, 2022 · 2 comments
Closed

[NME] Warning for protected block names pops while still typing #12715

PatrickRyanMS opened this issue Jul 7, 2022 · 2 comments
Assignees
Labels
bug nme Node Material Editor
Milestone

Comments

@PatrickRyanMS
Copy link
Member

When naming a block, we have a warning pop-up that informs the user that a block they have just named conflicts with protected block names in node material. However, this warning is popping up while the user is typing the name rather than when the user changes focus from the input field.

For example, if I am typing "normalTex" for the name of the block, the warning will pop when I type the "l" in "normal" and not input the "l". It seems that we should allow the user to finish typing and when they change focus by pressing "enter" or manually changing focus, we should then pop the warning and revert the name back to the block default rather than hijacking the field while typing.

Repro steps:

  1. open https://nme.babylonjs.com/
  2. click on the color4 block
  3. change name to "normalTex"
  4. note that you cannot type the full name without getting a popup that removes the "l" from the name even if focus on the input field is not lost.
@PatrickRyanMS PatrickRyanMS added bug nme Node Material Editor labels Jul 7, 2022
@PatrickRyanMS PatrickRyanMS added this to the 6.0 milestone Jul 7, 2022
@deltakosh
Copy link
Contributor

can you take care of this one @carolhmj please?

@deltakosh
Copy link
Contributor

I'll do it actually :D

deltakosh added a commit that referenced this issue Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug nme Node Material Editor
Projects
None yet
Development

No branches or pull requests

3 participants