-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a particles helper library #2445
Comments
I can do that. I'm open for more create methods like that :) |
The idea is to create one-liner for smoke, fire, etc... The json file could describe all parameters of each particle setup From a user standpoint, I see it like that:
The first parameter will look for a configuration named fire in the central json. The second one indicates that I want a GPU system (if the configuration allows it) I hope this makes sense:) |
Ok, nice, but the third argument for the ParticleSystem constructor is the Scene, so, Is there a way to get the scene, or we have to pass it to the main create() method too? |
Right:) we need a third one (optional as Engine.LastCreatedScene can be used) |
Great, I'll make a first try. Then we can discuss around that |
Wonderful!! |
Also, how can I correctly read a .json file in the /assets/particles folder, knowing that it becomes the domain name you told me? For now, I've already put that for basic textures that I will use but can I use it for the json file properly? private static _baseAssetsUrl = "https://assets.babylonjs.com/particles/"; |
This is fine! |
Where do you want I add a unit test for that? |
in /tests/unit please :) |
Yeah, of course, but i add a new file? |
Sure thing! |
But why there are no scripts in package.json to run tests? how do I launch these tests so? |
just go to /tools/gulp and run gulp tests-unit |
Something like createFire or createSmoke
The text was updated successfully, but these errors were encountered: