Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babylon.js uses deprecated WebRTC functionality that fails on Firefox and Edge #3825

Closed
veikkoeeva opened this issue Feb 26, 2018 · 1 comment
Closed
Assignees
Milestone

Comments

@veikkoeeva
Copy link

@veikkoeeva veikkoeeva commented Feb 26, 2018

  • Bug repro on https://www.babylonjs-playground.com/#1R77YT#2.
  • Expected result: The playground works and show the camera feed overlayed with ASCII art.
  • Current result: Black box is shown on Firefox (also nightly) and Edge, only Chrome (latest) seem to function.

It appears the code uses deprecated features, which Firefox calls out. Edge fails with the mention "not found". The following is a screenshot from Firefox developer tools:
deprecated

Using search, it appears this function (and functionality) is found in a few places: https://github.com/BabylonJS/Babylon.js/search?q=mozGetUserMedia&type=Code&utf8=%E2%9C%93. The way to fix could be something along these lines: https://github.com/webrtc/adapter/issues/772#issuecomment-364425723.

sebavan added a commit to sebavan/Babylon.js that referenced this issue Feb 26, 2018
sebavan added a commit that referenced this issue Feb 26, 2018
Fixed WebCam Texture on Firefox and Edge: #3825
@deltakosh deltakosh added this to the 3.2 milestone Feb 27, 2018
@sebavan
Copy link
Member

@sebavan sebavan commented Feb 27, 2018

Fixed and deployed.

@sebavan sebavan closed this Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants