Input management for cameras #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
March 5, 2016 17:44
|
|
||
| //deprecated | ||
| public set keysLeft(value) { | ||
| Tools.Warn("Warning: keysLeft is deprecated on ArcRotateCamera, use camera.inputs.attached.keyboard.keysLeft instead."); |
There was a problem hiding this comment.
Actually I won't mark them as deprecated. the path to reach the value is too long. Both can live together
|
OMG This is what I can call a PR :D Docs to be updated:
Thanks again 👍 |
|
|
||
| //Input manager | ||
| if (parsedCamera.inputs){ | ||
| camera.inputs.parse(parsedCamera); |
There was a problem hiding this comment.
This won't be called for old .babylon files
The condition has to be removed (I'll take care of it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be better