Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPU: more changes for fast path support + misc fixes #11374

Merged
merged 37 commits into from Nov 3, 2021
Merged

WebGPU: more changes for fast path support + misc fixes #11374

merged 37 commits into from Nov 3, 2021

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Nov 2, 2021 •
edited

New changes to avoid creating bundles in non compatibility mode.

Also:

  • added setMaterialForRendering to EffectLayer
  • improve perf when using the transmission helper
  • improve perf of SPS by updating directly the vertex buffers and not calling updateVerticesData (which dirtify the material)
  • fix occlusion queries not working anymore after the latest changes (drawWrappers)
  • fix updating the previous matrices for thin instances

@Popov72
Optimize updates of SPS attributes
2a4675c
@Popov72
Fix ubo mesh being updated two times in some cases
efe4cc0
@Popov72
"ignore" is not needed anymore in wgsl
7c47bb0
@Popov72
Fix crash when using scene.executeWhenReady before starting
0806e73
@Popov72
Mark defines from all draw wrappers as dirty
d5c5c47
@Popov72
Fix crash in latest Chrome Canary
d539b21
@Popov72
Add validation test for all procedural textures
5d5cf04
@Popov72
Add resetDrawCache method where needed
024ec17
@Popov72
Fix bundles being recreated in non compatibility mode
492dba2
@Popov72
Add missing dispose calls
5ad7418
@Popov72
Make sure no bundles are created each frame in the non compatibility …
391b120 
…mode
@Popov72
Fix validation tests for the non compatibility mode
4365aaa
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
e0f0c78 
… webgpu-fastpath2
@Popov72
Fix unncessary bundle recreations in the non compatibility mode in th…
6ed38d7 
…e transmission helper
@Popov72
Fix crash when changing the settings of GBR in WebGPU
d5f51a3
@Popov72
Fix usage of draw wrapper
b50474d
@Popov72
Fix updating the previousMatrix buffer
3736de4
@Popov72
Fix validation tests to avoid bundle recreations when in non compatib…
1f9ccf4 
…ility mode
@Popov72
Fix crash of the shadow depth wrapper test
93d4ccb
@Popov72
More fixing for the non compatibility mode
5200bc9
@Popov72
Fix occlusion queries after latest changes with DrawWrappers
dc37d94
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
07ff3c4 
… webgpu-fastpath2
sebavan
sebavan reviewed Nov 2, 2021
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only a couple neats

src/Engines/engine.ts Outdated Show resolved Hide resolved
src/Engines/nativeEngine.ts Outdated Show resolved Hide resolved
src/Engines/nullEngine.ts Outdated Show resolved Hide resolved
src/Engines/thinEngine.ts Outdated Show resolved Hide resolved
src/Engines/webgpuEngine.ts Outdated Show resolved Hide resolved
src/Layers/effectLayer.ts Show resolved Hide resolved
sebavan
sebavan approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!

@sebavan
Copy link
Member

sebavan commented Nov 3, 2021

@Popov72 maybe just a neat is to add more doc in the effectlayer/highlight/glow about all the effectIndex and such as it is not easy to grasp in maintenance ? would be awesome before we merge

@sebavan sebavan merged commit 2bbc6e3 into BabylonJS:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Popov72 @sebavan