WebGPU: more changes for fast path support + misc fixes

loaders/src/glTF/2.0/Extensions/KHR_materials_transmission.ts

@@ -254,11 +254,12 @@ class TransmissionHelper {
             } else {
                 opaqueRenderTarget.clearColor.copyFrom(this._options.clearColor);
             }
-            this._scene.imageProcessingConfiguration.applyByPostProcess = true;
+            // we do not use the applyByPostProcess setter to avoid flagging all the materials as "image processing dirty"!
+            this._scene.imageProcessingConfiguration._applyByPostProcess = true;
         });
         this._opaqueRenderTarget.onAfterUnbindObservable.add(() => {
             this._scene.environmentIntensity = saveSceneEnvIntensity;
-            this._scene.imageProcessingConfiguration.applyByPostProcess = sceneImageProcessingapplyByPostProcess;
+            this._scene.imageProcessingConfiguration._applyByPostProcess = sceneImageProcessingapplyByPostProcess;
         });
 
         this._transparentMeshesCache.forEach((mesh: AbstractMesh) => {

proceduralTexturesLibrary/src/cloud/cloudProceduralTexture.fragment.fx

@@ -19,7 +19,11 @@ float noise(vec2 n) {
 
 float fbm(vec2 n) {
 	float total = 0.0, ampl = amplitude;
+#ifdef WEBGL2
 	for (int i = 0; i < numOctaves; i++) {
+#else
+	for (int i = 0; i < 4; i++) {
+#endif
 		total += noise(n) * ampl;
 		n += n;
 		ampl *= 0.5;

src/Culling/boundingBox.ts

@@ -264,6 +264,14 @@ export class BoundingBox implements ICullable {
         return true;
     }
 
+    /**
+     * Disposes the resources of the class
+     */
+    public dispose(): void {
+        this._drawWrapperFront?.dispose();
+        this._drawWrapperBack?.dispose();
+    }
+
     // Statics
 
     /**

src/Engines/engine.ts

@@ -550,6 +550,8 @@ export class Engine extends ThinEngine {
             return;
         }
 
+        this._features.supportRenderPasses = true;
+
         options = this._creationOptions;
 
         if ((<any>canvasOrContext).getContext) {

src/Engines/engineFeatures.ts

@@ -63,6 +63,9 @@ export interface EngineFeatures {
     /** Indicates that even if we don't have to update the properties of a uniform buffer (because of some optimzations in the material) we still need to bind the uniform buffer themselves */
     needToAlwaysBindUniformBuffers: boolean;
 
+    /**  Indicates that the engine supports render passes */
+    supportRenderPasses: boolean;
+
     /** @hidden */
     _collectUbosUpdatedInFrame: boolean;
 }

src/Engines/index.ts

@@ -18,6 +18,7 @@ export * from "./WebGPU/webgpuCacheRenderPipeline";
 export * from "./WebGPU/webgpuCacheRenderPipelineTree";
 export * from "./WebGPU/webgpuCacheBindGroups";
 export * from "./WebGPU/webgpuCacheSampler";
+export * from "./WebGPU/webgpuDrawContext";
 export * from "./WebGPU/webgpuTintWASM";
 export * from "./WebGL/webGL2ShaderProcessors";
 export * from "./nativeEngine";

src/Engines/nativeEngine.ts

@@ -818,6 +818,7 @@ export class NativeEngine extends Engine {
             useUBOBindingCache: true,
             needShaderCodeInlining: true,
             needToAlwaysBindUniformBuffers: false,
+            supportRenderPasses: true,
             _collectUbosUpdatedInFrame: false,
         };
 

src/Engines/nullEngine.ts

@@ -173,6 +173,7 @@ export class NullEngine extends Engine {
             useUBOBindingCache: false,
             needShaderCodeInlining: false,
             needToAlwaysBindUniformBuffers: false,
+            supportRenderPasses: true,
             _collectUbosUpdatedInFrame: false,
         };
 

src/Engines/thinEngine.ts

@@ -1282,6 +1282,7 @@ export class ThinEngine {
             useUBOBindingCache: true,
             needShaderCodeInlining: false,
             needToAlwaysBindUniformBuffers: false,
+            supportRenderPasses: false,
             _collectUbosUpdatedInFrame: false,
         };
     }

src/Engines/webgpuEngine.ts

@@ -840,6 +840,7 @@ export class WebGPUEngine extends Engine {
             useUBOBindingCache: false,
             needShaderCodeInlining: true,
             needToAlwaysBindUniformBuffers: true,
+            supportRenderPasses: true,
             _collectUbosUpdatedInFrame: false,
         };
     }
@@ -1699,7 +1700,8 @@ export class WebGPUEngine extends Engine {
             }
         } else if (!effect.effect || effect.effect === this._currentEffect && effect.materialContext === this._currentMaterialContext && effect.drawContext === this._currentDrawContext && !this._forceEnableEffect) {
             if (!effect.effect && this.dbgShowEmptyEnableEffectCalls) {
-                console.warn("Invalid call to enableEffect: the effect property is empty! drawWrapper=", effect);
+                console.error("drawWrapper=", effect);
+                throw "Invalid call to enableEffect: the effect property is empty!";
             }
             return;
         } else {