Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBR thin instance color attribute needs to be pushed #12331

Closed
wants to merge 1 commit into from

Conversation

BlakeOne
Copy link
Contributor

@BlakeOne BlakeOne commented Apr 3, 2022

PBRBaseMaterial is missing the code to push the attribute for thin instance color. This PR just copies the same lines from StandardMaterial.

Here's a PG that shows the issue that's fixed by the PR, where the thin instances are black when they should be red.

Forum: https://forum.babylonjs.com/t/vertex-error-and-no-colors-on-thin-instances-after-upgrade/28492/12

@azure-pipelines
Copy link

We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12331/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12331/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12331/merge/index.html#WGZLGJ#4600

To test the snapshot in the playground itself use (for example):

https://playground.babylonjs.com/?snapshot=refs/pull/12331/merge#BCU1XR#0

@sebavan
Copy link
Member

sebavan commented Apr 4, 2022

Thanks a ton @BlakeOne, just noticed @CedricGuillemet had pushed the exact same fix :-) and I just merged it as it was at the top of the list. I am going to close your PR. Sorry to not have seen it earlier...

@sebavan sebavan closed this Apr 4, 2022
@sebavan
Copy link
Member

sebavan commented Apr 4, 2022

for reference #12333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants