Fix instance color forwarding for PBR Instances #12333
Conversation
|
We have noticed you haven't changes the "what's new.md" file. If your update is important (a bug fix, a new feature), please make sure to update the what's new file in the base directory and commit the changes. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12333/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12333/merge#BCU1XR#0 |
| @@ -1326,6 +1326,10 @@ export abstract class PBRBaseMaterial extends PushMaterial { | |||
| attribs.push(VertexBuffer.ColorKind); | |||
| } | |||
|
|
|||
| if (defines.INSTANCESCOLOR) { | |||
There was a problem hiding this comment.
This block of code is also missing in all materials of the material library (and maybe in some other materials, I know the fluent controls in 3D GUI are also using custom materials for eg).
I think it would be better to update the MaterialHelper.PrepareAttributesForInstances method to push VertexBuffer.ColorInstanceKind in the attribute list because this method is called each time instances/thin instances are supported by materials. This way, you won't have to update individually each material.
Followup https://forum.babylonjs.com/t/vertex-error-and-no-colors-on-thin-instances-after-upgrade/28492/13
Instance colors were not properly forwarded for PBR materials