Exposes framebufferScaleFactor to EngineOptions #12422
Conversation
|
Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12422/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12422/merge#BCU1XR#0 |
|
Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12422/merge/index.html#WGZLGJ#4600 To test the snapshot in the playground itself use (for example): https://playground.babylonjs.com/?snapshot=refs/pull/12422/merge#BCU1XR#0 |
There was a problem hiding this comment.
Thanks for the PR! I agree, it is an important option.
This is already possible using the canvas options provided to the default experience helper (if you are using it), or providing the option directly when creating the experience yourself.
For example:
await scene.createDefaultXRExperienceAsync({
outputCanvasOptions: {
canvasOptions: {
framebufferScaleFactor: aValueOtherThan1
}
}
});If that doesn't work it's a bug, but there is no need to add this (XR specific) feature to the thin engine.
|
That works perfectly, thank you! |
This change allows the engine user to adjust framebufferScaleFactor on engine creation. This option will allow to reduce resolution in XR mode. For devices like the Oculus Quest, that is imho a very important option.