Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb through useSRGBBuffer for _createInternalTexture. #12511

Merged
merged 2 commits into from
May 11, 2022

Conversation

kircher1
Copy link
Contributor

This is a follow up change to #12486; A little more plumbing is required to get the useSRGBBuffer value applied to the texture format. With current logic, fullOptions.useSRGBBuffer is always undefined.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@kircher1
Copy link
Contributor Author

Note, I plumbed this into the WebGPU implementation as well.

@azure-pipelines
Copy link

Please make sure to tag your PR with "bug", "new feature" or "breaking change" tags.

@azure-pipelines
Copy link

@deltakosh deltakosh merged commit fd8f526 into BabylonJS:master May 11, 2022
@kircher1 kircher1 deleted the users/briank/srgb-rt-plumbing branch August 26, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants