Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force render with just that camera on CreateScreenshot #12656

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Force render with just that camera on CreateScreenshot #12656

merged 3 commits into from
Jun 21, 2022

Conversation

carolhmj
Copy link
Contributor

If a camera is specified as an argument, fall back on the CreateScreenshotUsingRenderTarget function.
Related forum issue: https://forum.babylonjs.com/t/screenshot-tool-does-not-seem-to-respect-camera-argument/31167
Related Playground: https://playground.babylonjs.com/#M6HFGB

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@carolhmj carolhmj requested review from RaananW and sebavan June 20, 2022 15:29
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@RaananW RaananW enabled auto-merge (squash) June 21, 2022 10:13
@RaananW
Copy link
Member

RaananW commented Jun 21, 2022

Just need to run formatting :-)

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@RaananW RaananW merged commit d28c791 into BabylonJS:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants