Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceInputSystem: Fixed Passive Support Check to prevent Violation Warning #12696

Merged
merged 2 commits into from
Jun 30, 2022
Merged

DeviceInputSystem: Fixed Passive Support Check to prevent Violation Warning #12696

merged 2 commits into from
Jun 30, 2022

Conversation

PolygonalSun
Copy link
Contributor

There was a warning found by a user on the forums that, in Verbose mode, a Violation warning was occurring:
image
This warning was happening because the wheel event listener didn't have the "passive" option set to true when able. After closer investigation, it was found that the code used to determine if passive was supported was always returning false, causing this warning to occur. This PR modifies the logic to fix this.

Forum link: https://forum.babylonjs.com/t/bjs-console-warnings-when-using-cleargizmoonemptypointerevent/31447/8

@PolygonalSun PolygonalSun marked this pull request as ready for review June 29, 2022 22:16
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants