Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Tests on ProjectToPlane #12837

Merged
merged 1 commit into from Aug 4, 2022
Merged

More Tests on ProjectToPlane #12837

merged 1 commit into from Aug 4, 2022

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Aug 4, 2022

No description provided.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan requested a review from deltakosh August 4, 2022 16:59
@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12837/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12837/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12837/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12837/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12837/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12837/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12837/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12837/merge#BCU1XR#0

RaananW
RaananW approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests? Approved!!!
😄

@sebavan sebavan enabled auto-merge August 4, 2022 17:23
@sebavan sebavan merged commit 6bf4937 into BabylonJS:master Aug 4, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #12837 from sebavan/ProjectToPlane
1bba2b9 
More Tests on ProjectToPlane

Former-commit-id: 10d00b573dcd0411b4c71558834be9bb1a6b3992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW RaananW approved these changes

@deltakosh deltakosh Awaiting requested review from deltakosh

Assignees
No one assigned
Labels
skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebavan @RaananW