Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show full hex color on Color Picker component #12848

Merged
merged 1 commit into from Aug 8, 2022
Merged

Show full hex color on Color Picker component #12848

merged 1 commit into from Aug 8, 2022

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Aug 8, 2022

@carolhmj carolhmj added the bug label Aug 8, 2022
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

deltakosh
deltakosh approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make sure it work in NME and inspector as well?

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12848/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12848/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12848/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12848/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12848/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12848/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12848/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12848/merge#BCU1XR#0

@sebavan sebavan merged commit ee3bc84 into BabylonJS:master Aug 8, 2022
@carolhmj carolhmj deleted the ColorPickerComponentShowFullHexColor branch August 19, 2022 13:53
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #12848 from carolhmj/ColorPickerComponentShowFullH…
225c611 
…exColor

Show full hex color on Color Picker component

Former-commit-id: 12f473d15926eef188a6fc8a217862dd79ad1a7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carolhmj @deltakosh @sebavan