Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Update Safari Interactions test to point to BrowserStack #12883

Merged
merged 4 commits into from
Aug 24, 2022
Merged

Testing: Update Safari Interactions test to point to BrowserStack #12883

merged 4 commits into from
Aug 24, 2022

Conversation

PolygonalSun
Copy link
Contributor

There are slight modifications that have been made to the safari tests so that they use BrowserStack. This change should allow these tests to be used in the CI.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Contributor Author

@PolygonalSun PolygonalSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@PolygonalSun PolygonalSun marked this pull request as ready for review August 19, 2022 00:40
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would those test run locally (on the local version)? Can browserstack be set only when running in the CI? (or when setting a specific flag?)

@RaananW
Copy link
Member

RaananW commented Aug 24, 2022

@PolygonalSun - any update on this one?

@PolygonalSun
Copy link
Contributor Author

How would those test run locally (on the local version)? Can browserstack be set only when running in the CI? (or when setting a specific flag?)

Discussed offline

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@PolygonalSun PolygonalSun merged commit 6fe86e2 into BabylonJS:master Aug 24, 2022
@PolygonalSun PolygonalSun mentioned this pull request Aug 24, 2022
8 tasks
RaananW pushed a commit that referenced this pull request Dec 9, 2022
…2883)

* Basic BrowserStack integration

* Add console.log to see where BS is looking.

* Removed test console.log

* Add check for MacOS so tests can be run locally

Former-commit-id: 87a688f012f5cdbc3e462a0c1e5a3c8707f2c2e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants