Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Drag/Release Behavior in GUI and Photo Dome #12887

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

stevendelapena
Copy link
Contributor

See: https://forum.babylonjs.com/t/ispointerblocker-improvement/31152/10?u=stevendelapena

Recent changes to GUI mouse behavior breaks previous behavior for scenes utilizing a Video and Photo Domes. See PG: https://playground.babylonjs.com/#SQ5UC1#375 and https://playground.babylonjs.com/#14KRGG#715

Click and drag from outside of GUI element to gain control of camera. Release mouse from within the GUI element. You’ll notice the camera is still observing the mouse movement and pans around with mouse even though click/pointer has been released

Fix suggested is to allow mouse release to propagate to scene to allow for release of camera observers.

Fix to allow mouse release to propagate to scene to allow for release of camera observers. See: https://forum.babylonjs.com/t/ispointerblocker-improvement/31152/10?u=stevendelapena
Fix Drag/Release Behavior in GUI and Photo Dome
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@OPSnake
Copy link

OPSnake commented Aug 22, 2022

I have same problem in my app and it's solved with your fix 👍

Copy link
Contributor

@PolygonalSun PolygonalSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@carolhmj carolhmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! :D

@carolhmj carolhmj merged commit 15fd365 into BabylonJS:master Aug 22, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Fix Drag/Release Behavior in GUI and Photo Dome

Former-commit-id: 9975f45f8c4772c9af04771a24541bae299dd158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants