Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "metadata" support to "ReflectionProbe" class #12911

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

julien-moreau
Copy link
Contributor

No description provided.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

There is no need to update the "what's new.md" file. A changelog will be generated using the PR and its tags.

@deltakosh deltakosh enabled auto-merge (squash) August 29, 2022 16:18
@azure-pipelines
Copy link

@deltakosh deltakosh merged commit 57ec551 into BabylonJS:master Aug 29, 2022
@@ -74,6 +74,11 @@ export class ReflectionProbe {
@serializeAsVector3()
public position = Vector3.Zero();

/**
* Gets or sets an object used to store user defined information for the sound.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sound => probe

Copy link
Contributor Author

@julien-moreau julien-moreau Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG nice catch, thanks!!

RaananW pushed a commit that referenced this pull request Dec 9, 2022
Former-commit-id: ef05293305573dd03cf67f04967657dc68a5efe3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants