Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance mode #12954

Merged
merged 8 commits into from
Sep 7, 2022
Merged

Performance mode #12954

merged 8 commits into from
Sep 7, 2022

Conversation

deltakosh
Copy link
Contributor

@deltakosh deltakosh commented Sep 6, 2022

The goal is to protect backward compatibility but also offer an option for users to say they are ok to not be backward compatible (OR less easy to use) to favor perf by default

@deltakosh deltakosh marked this pull request as draft September 6, 2022 18:21
@sebavan
Copy link
Member

sebavan commented Sep 6, 2022

Love it :-)

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh
Copy link
Contributor Author

One thing I will do after merging this (when we are all ok with it) will be to document the consequences. What you will lose /have to pay to get to the best performance

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Do we want to maintain backwards compatibility when people set to Aggressive? I.e., if later, we decided that more things need to change for Aggressive mode, can we update it?

packages/dev/core/src/scene.ts Outdated Show resolved Hide resolved
packages/dev/core/src/scene.ts Show resolved Hide resolved
@deltakosh
Copy link
Contributor Author

I like it. Do we want to maintain backwards compatibility when people set to Aggressive? I.e., if later, we decided that more things need to change for Aggressive mode, can we update it?

Nope, I will quote that in the doc. Aggressive is not backward compatible

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/dev/core/src/Meshes/abstractMesh.ts Show resolved Hide resolved
packages/dev/core/src/scene.ts Show resolved Hide resolved
packages/dev/core/src/scene.ts Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12954/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@deltakosh deltakosh marked this pull request as ready for review September 7, 2022 17:33
@deltakosh deltakosh changed the title Really first draft Performance mode Sep 7, 2022
@sebavan sebavan merged commit 474fa9c into master Sep 7, 2022
@sebavan sebavan deleted the scene-perf branch September 7, 2022 20:52
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Performance mode

Former-commit-id: efe52af47b37e14ff5c758a80c40a4bf0f64afef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants