Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More features for the aggressive performance mode #13014

Merged
merged 1 commit into from Sep 22, 2022
Merged

More features for the aggressive performance mode #13014

merged 1 commit into from Sep 22, 2022

Conversation

deltakosh
Copy link
Contributor

Some tiny perf changes + a major one: Now in aggressive mode, the renderingGroups are not reset between frames.

@deltakosh deltakosh enabled auto-merge (squash) September 22, 2022 18:45
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@deltakosh deltakosh merged commit 3de4f3d into master Sep 22, 2022
@deltakosh deltakosh deleted the cleanup branch September 22, 2022 19:39
* Gets or sets a boolean indicating that the manager will not reset between frames.
* This means that if a mesh becomes invisible or transparent it will not be visible until this boolean is set to false again.s
*/
public maintainStateBetweenFrames = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will need a setter that will reset all the _wasDispatched properties to false when maintainStateBetweenFrames is switched from true to false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this is a good catch! PR is coming!

RaananW pushed a commit that referenced this pull request Dec 9, 2022
Former-commit-id: c855d23a3aca8bf7a644128d6dd697bd22254853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants