Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore wasDispatched to false when MaintainStateBetweenFrames is set to false #13019

Merged
merged 5 commits into from
Sep 26, 2022
Merged

Restore wasDispatched to false when MaintainStateBetweenFrames is set to false #13019

merged 5 commits into from
Sep 26, 2022

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh changed the title Restore was disptached Restore wasDispatched to false when MaintainStateBetweenFrames is set to false Sep 23, 2022
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13019/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13019/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13019/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13019/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13019/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13019/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13019/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13019/merge#BCU1XR#0

Popov72
Popov72 approved these changes Sep 23, 2022
View reviewed changes
packages/dev/core/src/Rendering/renderingManager.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Rendering/renderingManager.ts Outdated Show resolved Hide resolved
@sebavan sebavan merged commit 688561b into master Sep 26, 2022
@sebavan sebavan deleted the restore-wasDisptached branch September 26, 2022 18:40
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13019 from BabylonJS/restore-wasDisptached
3b04ec7 
Restore wasDispatched to false when MaintainStateBetweenFrames is set to false

Former-commit-id: ea33f15eb93beb810f88bab51000d37102ad5244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deltakosh @Popov72 @sebavan