Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth of field optimizations and cleanup #13110

Merged
merged 9 commits into from
Oct 13, 2022

Conversation

kircher1
Copy link
Contributor

The main change here is to use R-only texture format for the circle of confusion (which only needs to store a single value per pixel) rather than using an RGBA texture. This will save space and should be more bandwidth efficient to sample from during the subsequent blur passes.

Also removes sampleDistance from the blur shader-- it's not used AFAICT and deleting this code removes the need for passing cameraMinMaxZ uniform.

Other changes here are just minor cleanup.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@azure-pipelines
Copy link

auto-merge was automatically disabled October 13, 2022 19:48

Head branch was pushed to by a user without write access

@sebavan sebavan merged commit 1650f38 into BabylonJS:master Oct 13, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Depth of field optimizations and cleanup

Former-commit-id: 16da49e930014f56baa4f3c553d8ee49de0455c9
@kircher1 kircher1 deleted the dof-opts-and-cleanup branch September 2, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants