Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test babylon transform node #13181

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Conversation

Dok11
Copy link
Contributor

@Dok11 Dok11 commented Oct 28, 2022

Hi!
The url https://doc.babylonjs.com/how_to/parenting currently is 404, so I updated it.

And one strange momemnt to me. I tried to write test case like this:

const scene = new Scene(subject);
const child = new AbstractMesh("Child", scene);
const parent = new AbstractMesh("Parent", scene);

child.rotationQuaternion = new Quaternion(0.1, 0.2, 0.3, 1);
child.setParent(parent);

After setParent the child.rotationQuaternion equals to {"_isDirty": true, "_w": 0.9193215324678584, "_x": 0.10613875217731637, "_y": 0.21264414489225805, "_z": 0.31622577190124856}
It happens after call composedMatrix.decompose() in the setParent() method.
I don't know, is this behaviour correct?

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 25e1881 into BabylonJS:master Oct 28, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Test babylon transform node

Former-commit-id: 22bd0d6e945d61324ecf19940dc001fb892322bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants