Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Physics V2 plugin iteration #13352

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Physics V2 plugin iteration #13352

merged 4 commits into from
Jan 4, 2023

Conversation

CedricGuillemet
Copy link
Contributor

Minor updates to the plugin interface, physics debug viewer and small fixes.

@sebavan sebavan marked this pull request as draft December 16, 2022 20:33
@CedricGuillemet CedricGuillemet marked this pull request as ready for review January 3, 2023 16:13
sebavan
sebavan approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me aside of the empty

   /**
     *
     */

@sebavan sebavan requested a review from RaananW January 3, 2023 22:59
@CedricGuillemet
Copy link
Contributor Author

Looks good to me aside of the empty

   /**
     *
     */

For this PR and the 2 or 3 coming next, methods, signatures,...everything that is internal will change. Comments will be written when it won't be just internal.

@CedricGuillemet CedricGuillemet merged commit 61df194 into BabylonJS:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

@RaananW RaananW Awaiting requested review from RaananW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CedricGuillemet @RaananW @sebavan @CedricGuillemetMS