Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics V2 Iteration 3 #13450

Merged
merged 7 commits into from
Jan 23, 2023

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Jan 18, 2023

Iteration 3 featuring:

  • More code documentation
  • Transform <-> Body synchronization
  • Typos
  • Engine Component using TransformNode instead of Mesh

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan requested a review from RaananW January 18, 2023 17:46
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2023

@CedricGuillemet CedricGuillemet marked this pull request as draft January 18, 2023 18:39
@RaananW
Copy link
Member

RaananW commented Jan 18, 2023

Looks great. i'll follow this PR and fully review it when it is our of draft mode

@CedricGuillemet CedricGuillemet marked this pull request as ready for review January 19, 2023 17:56
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you did there !!!! :-)

@sebavan
Copy link
Member

sebavan commented Jan 20, 2023

I think it is all good for review @RaananW

@CedricGuillemet CedricGuillemet merged commit 3e09d26 into BabylonJS:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants