Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fix for UMD modules typing #13624

Merged
merged 2 commits into from Mar 14, 2023
Merged

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Mar 14, 2023

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW enabled auto-merge (squash) March 14, 2023 11:40
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 14, 2023

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaananW anything possible to prevent it to happen ?

@RaananW
Copy link
Member Author

RaananW commented Mar 14, 2023

@RaananW anything possible to prevent it to happen ?

This was an error in import type and not import.
imports will fail, import type are harder to solve. But I am on it.

@RaananW RaananW merged commit b007f5a into BabylonJS:master Mar 14, 2023
8 checks passed
@slang123
Copy link

slang123 commented Apr 13, 2023

I am still getting an error when importing.
Error: node_modules/babylonjs/babylon.module.d.ts:87877:45 - error TS2307: Cannot find module 'babylonjs/Meshes' or its corresponding type declarations.

87877 import { TransformNode, AbstractMesh } from "babylonjs/Meshes";

I'm in version:
"babylonjs": "^5.55.0",
"babylonjs-loaders": "^5.55.0",

@sebavan sebavan mentioned this pull request Apr 13, 2023
@sebavan
Copy link
Member

sebavan commented Apr 13, 2023

@slang123 the PR will fix this one

@RaananW There was 2 import types issues reported today :-) so the investment will be worth it.

@RaananW
Copy link
Member Author

RaananW commented Apr 13, 2023

@slang123 the PR will fix this one

@RaananW There was 2 import types issues reported today :-) so the investment will be worth it.

I'll have that working soon. Will probably require compiling the TS devhost package, but, as you say, it's worth the effort. Or better yet - we must do it.

@RaananW RaananW deleted the fixTypings branch April 17, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants