DeviceEventFactory: Modified event factory to provide correct value for buttons property #13927
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13927/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13927/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13927/merge#BCU1XR#0 |
Yeah, I found an issue with a bool in InputManager, I've pushed a fix for that. |
|
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
There was an issue brought up where drag controls where not "letting go" when the mouse button was released. This PR will now properly propagate this value based off of the MouseEvent standard.
Edit: This also contains a little change to out pointer capture is being handled. Basically, if the POINTERDOWN is skipped, the pointer capture bool is still set to true and if the POINTERUP is skipped and there are no buttons pressed, it should be released.