Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceEventFactory: Modified event factory to provide correct value for buttons property (part deux) #14043

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

PolygonalSun
Copy link
Contributor

This PR is a fix to #13927. It addresses some of the logic changes but also re-adds support for buttons in Native pointer events.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 12, 2023

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! makes sense (especially setting the buttons value correctly)

Copy link
Contributor

@CedricGuillemet CedricGuillemet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK with gizmo PG

@PolygonalSun PolygonalSun marked this pull request as ready for review July 12, 2023 16:07
@PolygonalSun PolygonalSun merged commit 2ad81e9 into BabylonJS:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants