changeable epsilon for (typeof Quaternion).FromUnitVectorsToRef #13983
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13983/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13983/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13983/merge#BCU1XR#0 |
| @@ -4664,10 +4664,10 @@ export class Quaternion { | |||
| * @param result the quaternion to store the result | |||
| * @returns the updated quaternion | |||
| */ | |||
| public static FromUnitVectorsToRef<T extends Quaternion>(vecFrom: DeepImmutable<Vector3>, vecTo: DeepImmutable<Vector3>, result: T): T { | |||
| public static FromUnitVectorsToRef<T extends Quaternion>(vecFrom: DeepImmutable<Vector3>, vecTo: DeepImmutable<Vector3>, result: T, epsilon = Epsilon): T { | |||
There was a problem hiding this comment.
The doc for epsilon is missing in the function description.
|
I wonder what purpose this epsilon check serves? Is it optimization or function might break, if dot product is near zero. |
It's to avoid breaking because of limited precision: https://blog.demofox.org/2017/11/21/floating-point-precision/ |
for my use case epsilon is to big, so right now I have to copy entire method and use 1e-7 epsilon which works fine for me
I hope optional parameter for epsilon is fine