Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use exec instead of matchAll while keeping structure #13986

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jun 20, 2023

Babylon native's js engine doesn't support matchAll (an ES2020 feature).

Instead, I am recreating the same structure using .exec.

Performance-wise it is on-par and even faster (at least on my benchmarks. See here - https://jsbench.me/wblj4eghw5/1)

image

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 20, 2023

@RaananW RaananW enabled auto-merge June 20, 2023 15:32
@RaananW RaananW merged commit e96bcc9 into BabylonJS:master Jun 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants