Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nme fix2 #14120

Merged
merged 12 commits into from
Aug 3, 2023
Merged

Nme fix2 #14120

merged 12 commits into from
Aug 3, 2023

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh requested a review from carolhmj August 3, 2023 15:51
@deltakosh
Merge branch 'master' into nme-fix2
4ffdff0
@deltakosh
Merge remote-tracking branch 'remotes/origin/master' into nme-fix2
2728f62 
# Conflicts:
#	packages/dev/core/src/Materials/Node/Blocks/Teleport/teleportInBlock.ts
#	packages/dev/sharedUiComponents/src/nodeGraphSystem/graphNode.ts
#	packages/dev/sharedUiComponents/src/nodeGraphSystem/interfaces/displayManager.ts
#	packages/dev/sharedUiComponents/src/nodeGraphSystem/tools.ts
#	packages/tools/nodeEditor/src/graphSystem/display/teleportInDisplayManager.ts
#	packages/tools/nodeEditor/src/graphSystem/display/teleportOutDisplayManager.ts
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 3, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 3, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 3, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 3, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh enabled auto-merge (squash) August 3, 2023 16:31
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 3, 2023

Snapshot stored with reference name:
refs/pull/14120/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14120/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14120/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14120/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14120/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14120/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14120/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14120/merge#BCU1XR#0

@deltakosh deltakosh merged commit 5ef2dac into master Aug 3, 2023
9 checks passed
@deltakosh deltakosh deleted the nme-fix2 branch August 3, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolhmj carolhmj carolhmj approved these changes

Assignees
No one assigned
Labels
skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deltakosh @bjsplat @carolhmj