Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bone IK controller: Make sure the absolute matrices are up to date #14151

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Aug 11, 2023

See https://forum.babylonjs.com/t/boneikcontroller-demo-broken/43211

This bug appeared after my changes to the bone class because BoneIKController relied on a bug in the old Bone class, where the absolute transformation matrix had a value, but a wrong one - it contained the absolute bind matrix instead of the absolute matrix! To make sure we get up-to-date absolute matrices, we need to call skeleton.computeAbsoluteMatrices().

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 11, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 11, 2023

@deltakosh deltakosh merged commit ca250f2 into BabylonJS:master Aug 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants