P8 NGE linear and radial cloner blocks

[Pryme8]

https://forum.babylonjs.com/t/nge-linear-cloner/43369

Just a simple linear cloner.

Only supports uv0 right now.

Probably should add color support as well.

[bjsplat]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[deltakosh]

Why not cloning with vertexData.clone and then applying the correct transformations on each clone?

something like that:

const geometry = (value as VertexData).clone();
                    geometry.transform(matrix);
                    return geometry;

where matrix is the overall transformation build from the parameters you have on the block

[Pryme8]

Why not cloning with vertexData.clone and then applying the correct transformations on each clone?

something like that:

const geometry = (value as VertexData).clone();
                    geometry.transform(matrix);
                    return geometry;

where matrix is the overall transformation build from the parameters you have on the block

I had no clue you could do this, will have to refactor it to use that.

[bjsplat]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[bjsplat]

Snapshot stored with reference name:
refs/pull/14172/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14172/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14172/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14172/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14172/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14172/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14172/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14172/merge#BCU1XR#0

[deltakosh]

Ok I feel like we need a general clone as well. Something that takes a geometry, a count, a rotation/scaling/translation and simply instantiate the geometry n times. The inputs (geometry and transformation can be static or dynamic if for instance we create a new CloneID value that will give you the current index (from 0 to count). I will add this node after we have merged this PR :)

[deltakosh]

@Pryme8 just for naming my block will be CloneBlock so maybe we can name yours LinearCloneBlock and RadialCloneBlock?

[deltakosh]

@Pryme8 any update buddy?

[Pryme8]

I totally spaced out about these, my bad. Ill try go resolve this stuff today or tomorrow!

[deltakosh]

Everything is fine. We simply need to look at the way InstantiateBlock operates and do the same.

[Pryme8]

@deltakosh should be good to go now!

[deltakosh]

Thanks!!

[deltakosh]

Ok sorry to be a pain :)

Here is my idea: as these 2 classes are almost a clone of InstantiateBlock, what if we simply inherits from it and replace the '_buildBlock' function?

Also @PatrickRyanMS, regarding naming, maybe we should name then like LinearInstantiateBlock and RadialInstantiateBlock?

[PatrickRyanMS]

Ok sorry to be a pain :)

Here is my idea: as these 2 classes are almost a clone of InstantiateBlock, what if we simply inherits from it and replace the '_buildBlock' function?

Also @PatrickRyanMS, regarding naming, maybe we should name then like LinearInstantiateBlock and RadialInstantiateBlock?

I would suggest we follow the same format we've already established with the word "instantiate" first so that all nodes in the instances group begin with "instantiate." So instantiateLinear and instantiateRadial. I would also suggest to order them in the node list right beneath instantiate in alpha order:

• instantiate
• instantiateLinear
• instantiateRadial
• instantiateOnFaces
• instantiateOnVertices
• instantiateOnVolume

[Pryme8]

Ok, if I get a chance tonight ill fix that up. If not then it will have to be tomorrow while I'm off work!

[Pryme8]

Finally was able to get to this, sorry about the delay.
@deltakosh

[Pryme8]

its yelling at me about the linting but when I do npm run lint it only brings up warnings about js docs?

[sebavan]

cc @RaananW for the lint/format issue.

[RaananW]

this is the formatting issue

[Pryme8]

Is it time to roll the beautiful bean footage?

[deltakosh]

Almost there ;)

[deltakosh]

Thanks a ton @Pryme8 !!!