Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new NGE block: Instantiate #14196

Merged
merged 4 commits into from
Aug 23, 2023
Merged

new NGE block: Instantiate #14196

merged 4 commits into from
Aug 23, 2023

Conversation

deltakosh
Copy link
Contributor

The new instantiate node:
image

I also introduced the notion of LoopID contextual value that let you control the transform per step

cc @Pryme8 @PatrickRyanMS

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 23, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 23, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 23, 2023

@PatrickRyanMS
Copy link
Member

@deltakosh, I ran through a bunch of scenarios in my head on this node and I couldn't find one that failed. I think this is good to go.

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside of a small nit but I know nothing of the NGE code so would be good to get @Popov72 eyes as well on it ?

@deltakosh deltakosh enabled auto-merge (squash) August 23, 2023 20:21
@deltakosh deltakosh merged commit ea5acd8 into master Aug 23, 2023
10 checks passed
@deltakosh deltakosh deleted the instantiateBLock branch August 23, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants