Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interpolation option for varying in WGSL #14893

Merged
merged 1 commit into from Mar 25, 2024

Conversation

XanthosXanthopoulos
Copy link
Contributor

In the current version, when preprocessing a WGSL shader the interpolation options are ignored making it impossible to use non f32 based types which require @interpolate(flat). With the proposed changes both interpolation type and sampling can be specified in a similar fashion as in GLSL shaders.

Reference: https://www.w3.org/TR/WGSL/#interpolation

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 21, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 21, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 21, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 21, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14893/merge/testResults/webgpuplaywright/index.html

@RaananW RaananW requested a review from Popov72 March 21, 2024 18:44
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !!! Let s wait on @Popov72 to be fully safe. :-)

@RaananW RaananW merged commit a23249c into BabylonJS:master Mar 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants