Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glTF animation pointer of metallic roughness texture #14936

Merged
merged 2 commits into from Apr 2, 2024

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Apr 1, 2024

Also adds some checks to runtime animation to throw an error if the given property path is invalid.

See forum: https://forum.babylonjs.com/t/khr-animation-pointer-with-uv-transforms/49081/18

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 1, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh enabled auto-merge (squash) April 1, 2024 22:36
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 1, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 1, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 1, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14936/merge/testResults/webgpuplaywright/index.html

@deltakosh
Copy link
Contributor

You need to merge from master to get rid of the unit test issue

@deltakosh deltakosh disabled auto-merge April 1, 2024 23:02
@bghgary bghgary enabled auto-merge (squash) April 1, 2024 23:39
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 2, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14936/merge/testResults/webgpuplaywright/index.html

@bghgary bghgary merged commit d24425c into BabylonJS:master Apr 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants