Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing errors when compiling UMD types #15092

Merged
merged 3 commits into from
May 13, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented May 13, 2024

This will fix the issue found on thursday (preventing ts playgrounds from running)

@bjsplat
Copy link
Collaborator

bjsplat commented May 13, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh enabled auto-merge (squash) May 13, 2024 14:00
@bjsplat
Copy link
Collaborator

bjsplat commented May 13, 2024

@RaananW RaananW disabled auto-merge May 13, 2024 14:11
@RaananW
Copy link
Member Author

RaananW commented May 13, 2024

Adding a test so it won't happen again

@bjsplat
Copy link
Collaborator

bjsplat commented May 13, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15092/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 13, 2024

@RaananW RaananW marked this pull request as draft May 13, 2024 14:27
@RaananW RaananW marked this pull request as ready for review May 13, 2024 15:05
@RaananW
Copy link
Member Author

RaananW commented May 13, 2024

@deltakosh - I made some rename changes to the shares ui components library to avoid duplication, otherwise inspector, nme, nge declarations were failing standard tsc call. Want to review this again?

@bjsplat
Copy link
Collaborator

bjsplat commented May 13, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15092/merge/testResults/webgpuplaywright/index.html

@sebavan sebavan merged commit 8f90660 into BabylonJS:master May 13, 2024
11 checks passed
@RaananW RaananW deleted the fixInspectorTypingExport branch May 13, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants