Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nine patch for fox UIs with ideal width and ideal height #15110

Merged
merged 1 commit into from
May 16, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented May 16, 2024

Playground to test with:

#QMQI2Z#5

or

#QMQI2Z#1

@bjsplat
Copy link
Collaborator

bjsplat commented May 16, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this one (there have been so many updates to this code)!

@RaananW
Copy link
Member Author

RaananW commented May 16, 2024

The general gist - this only changes the scenario to ADTs with idealWidth or idealHeight, which auto-adjusts the size of the image. In this case, it would be expected that the 9 portions of the image would also adjust accordingly. Conversation is here - https://forum.babylonjs.com/t/gui-9-patch-stretch-not-working-well-with-adaptive-scaling/48635?u=raananw

@bjsplat
Copy link
Collaborator

bjsplat commented May 16, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented May 16, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15110/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 16, 2024

@sebavan sebavan merged commit d7d7ad8 into BabylonJS:master May 16, 2024
11 checks passed
@RaananW RaananW deleted the ninePatchAdjustFix branch May 16, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants