-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Playground loading on custom SnippetID #15264
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15264/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15264/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15264/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
@RaananW for your information, if you need to access a custom playground but run into the loading bug, you can access a clean playground (https://playground.babylonjs.com) and then add the ID to it |
In my last PR adding the procedural code generator, I inserted the JSON fetch in the monacoEditor constructor, to make sure it was loaded first, but the
_load
function was called after the fetch, which could lead to "forever" engine loading UI in the event of loading a custom PG._load
beforefetch
)uncacher
param to the JSON urls (since it's very light) :const url = "templates.json?uncacher="+Date.now();
"\n"
at beginning of generated code was added