Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Playground loading on custom SnippetID #15264

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

Tricotou
Copy link
Contributor

In my last PR adding the procedural code generator, I inserted the JSON fetch in the monacoEditor constructor, to make sure it was loaded first, but the _load function was called after the fetch, which could lead to "forever" engine loading UI in the event of loading a custom PG.

  • This PR fixes the previous issue. (--> _load before fetch)
  • It also fixes the potential cache issue by adding an uncacher param to the JSON urls (since it's very light) :
    const url = "templates.json?uncacher="+Date.now();
  • Missing "\n" at beginning of generated code was added

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW enabled auto-merge (squash) July 10, 2024 14:37
@RaananW RaananW disabled auto-merge July 10, 2024 14:37
@RaananW RaananW enabled auto-merge (squash) July 10, 2024 14:37
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 10, 2024

@RaananW RaananW merged commit 8bc5656 into BabylonJS:master Jul 10, 2024
10 of 12 checks passed
@Tricotou
Copy link
Contributor Author

@RaananW for your information, if you need to access a custom playground but run into the loading bug, you can access a clean playground (https://playground.babylonjs.com) and then add the ID to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants