-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JSON-based procedural code generator to the Playground #15243
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15243/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15243/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15243/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
1 similar comment
Visualization tests for WebGPU (Experimental) |
Lets see if @PatrickRyanMS can tests the code to validate the UI/UX? and if @RaananW can check the code :-) |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
Catching the JSON fetch + decode, in order to avoid braking the playground in the event of pushing a broken JSON (tested with broken JSON) |
Sorry fro taking the time here, was preoccupied with other tasks. I will review this PR today |
Code-wise I am perfectly fine with it. I'll wait for @PatrickRyanMS to try this out and give some feedback, when he has the time. Just an opinion - I think that as a feature it is a nice idea, but this needs to be very carefully implemented. Not sure i am 100% fine with the UX here. |
I am out of the office for the US holiday. I will be back on Monday and able to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks AWESOME!
Love it
I merged to have it used by people and we can do a new PR if we want improved UX |
|
This PR is following the same topic on the forum
tools/playground/public/templates.json
)tools/playground/public/procedural.json
which is used to build the drop down menu ✔️fetch("templates.json").then()
has been move to the monaco constuctor since now it's used from different places.NB:
the code generator is not "100%" based on the JSON (for now...?) since some conditions have been included outside, such as for example ashadowGenerator
check (cannot be enabled on hemi light), etc.NB:
In the monaco editor I added aif (model.isDisposed())
check (see line 720 & 727), but I could not find exactly when the errorModel is disposed!
is triggered. Seems to be a bit random 🤔Demo : https://github.com/BabylonJS/Babylon.js/assets/167624418/6b95747b-8f10-42ca-955a-46dc873e0f96