Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate HDRTools to functions #15377

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Conversation

james-pre
Copy link
Contributor

This PR migrates HDRTools to ES6/functions. It is for #14805.

I've included an HDRTools object marked as deprecated, for backward compatibility.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2024

@deltakosh deltakosh requested a review from RaananW August 7, 2024 23:24
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 8, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15377/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 8, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15377/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to use PascalCasing

@RaananW
Copy link
Member

RaananW commented Aug 8, 2024

Same comment regarding index.ts here as well

@RaananW RaananW dismissed deltakosh’s stale review August 8, 2024 17:48

Changes were already made

@RaananW RaananW merged commit d1e7b61 into BabylonJS:master Aug 8, 2024
10 of 12 checks passed
@james-pre james-pre deleted the migrate-hdrtools branch August 8, 2024 21:54
@james-pre james-pre changed the title Migrate HDRTools to ES6/functions Migrate HDRTools to functions Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants