-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ArrayTools
to functions
#15385
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15385/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15385/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15385/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
Same thing regarding export from index. And let's delay further changes to these classes. Whereas I agree that a class with only static members is simply an object, there are some minor differences that we need to consider (for example, docs are suddenly different). |
Funny enough,
Sounds good, we can talk about this more on the forums. |
If it is internal there is no need to export it, and there is no need to create an object for it. Can simply be converted to functions |
Got it, I removed the |
ArrayTools
from a static class to functionsArrayTools
to functions
This PR migrates
ArrayTools
from a class with static methods and properties into a set of export functions.