Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.basis file support #6387

Merged
merged 11 commits into from May 31, 2019
Merged

.basis file support #6387

merged 11 commits into from May 31, 2019

Conversation

TrevorDev
Copy link
Contributor

#6382

TestPG: #4RN0VF

image

@TrevorDev TrevorDev requested a review from bghgary May 23, 2019 23:16
@deltakosh deltakosh requested a review from sebavan May 24, 2019 01:19
deltakosh
deltakosh reviewed May 24, 2019
View reviewed changes
src/Misc/basis.ts Outdated Show resolved Hide resolved
deltakosh
deltakosh reviewed May 25, 2019
View reviewed changes
src/Engines/engine.ts Outdated Show resolved Hide resolved
@deltakosh
Copy link
Contributor

Only doc check is missing

@deltakosh
Copy link
Contributor

still a doc issue :)

@deltakosh deltakosh merged commit 05488c5 into BabylonJS:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh left review comments

@bghgary bghgary Awaiting requested review from bghgary

@sebavan sebavan Awaiting requested review from sebavan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrevorDev @deltakosh