Loading screen interface and implementation #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow an easy way to replace the default loading screen. The default implementation is included as well.
The engine now has a loadingScreen variable. For legacy reasons all functions (get and set background etc') are still there, but should be removed in future releases.
And type fix. Typescript compiles.
removed the unneeded properties (breaking change)
missing file
|
Hello I think this is great but I would like to keep the set loading text and background color on the engine. This then will be sent to the interface. If someone wants to have a loader which does not take this in account that's fine but I think this is a good first level of customization without having to completely rewrite a loader |
|
Will make the changes and commit soon |
Supports the engine methods.
|
Interface and engine updated (including a small and silly bug fix). |
deltakosh
added a commit
that referenced
this pull request
Sep 24, 2015
Loading screen interface and implementation
|
Another small ask :) can you update the file list here:https://github.com/BabylonJS/Documentation/blob/master/content/generals/General/Creating_the_Mini-fied_Version.md |
|
updating the documentation now. |
|
Lol this is fast:) thank you! |
|
I'm only fast when I am sitting in front of my computer 😄 |
|
I hope so :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to create a new implementation of the loading screen and set it in the engine.
The engine now includes a loadingScreen variable that is per default the native loading screen but can be set with a new loading screen in accordance to the ILoadingScreen interface.
Breaking changes
the engine's set loading text and set background color were removed as they are no longer conform with the new interface!