New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading screen interface and implementation #700

Merged
merged 11 commits into from Sep 24, 2015

Conversation

Projects
None yet
2 participants
@RaananW
Member

RaananW commented Sep 24, 2015

It is now possible to create a new implementation of the loading screen and set it in the engine.
The engine now includes a loadingScreen variable that is per default the native loading screen but can be set with a new loading screen in accordance to the ILoadingScreen interface.

Breaking changes
the engine's set loading text and set background color were removed as they are no longer conform with the new interface!

RaananW added some commits Sep 23, 2015

Adding a loading screen interface and default impl.
This will allow an easy way to replace the default loading screen.
The default implementation is included as well.
Engine changes
The engine now has a loadingScreen variable. For legacy reasons all
functions (get and set background etc') are still there, but should be
removed in future releases.
Adding mixxing properties
And type fix.
Typescript compiles.
engine cleanup
removed the unneeded properties (breaking change)
@deltakosh

This comment has been minimized.

Show comment
Hide comment
@deltakosh

deltakosh Sep 24, 2015

Contributor

Hello I think this is great but I would like to keep the set loading text and background color on the engine. This then will be sent to the interface. If someone wants to have a loader which does not take this in account that's fine but I think this is a good first level of customization without having to completely rewrite a loader

Contributor

deltakosh commented Sep 24, 2015

Hello I think this is great but I would like to keep the set loading text and background color on the engine. This then will be sent to the interface. If someone wants to have a loader which does not take this in account that's fine but I think this is a good first level of customization without having to completely rewrite a loader

@RaananW

This comment has been minimized.

Show comment
Hide comment
@RaananW

RaananW Sep 24, 2015

Member

Will make the changes and commit soon

Member

RaananW commented Sep 24, 2015

Will make the changes and commit soon

@RaananW

This comment has been minimized.

Show comment
Hide comment
@RaananW

RaananW Sep 24, 2015

Member

Interface and engine updated (including a small and silly bug fix).

Member

RaananW commented Sep 24, 2015

Interface and engine updated (including a small and silly bug fix).

deltakosh added a commit that referenced this pull request Sep 24, 2015

Merge pull request #700 from RaananW/loadingScreen
Loading screen interface and implementation

@deltakosh deltakosh merged commit 87190e1 into BabylonJS:master Sep 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@deltakosh

This comment has been minimized.

Show comment
Hide comment
Contributor

deltakosh commented Sep 24, 2015

@RaananW RaananW deleted the RaananW:loadingScreen branch Sep 24, 2015

@RaananW

This comment has been minimized.

Show comment
Hide comment
@RaananW

RaananW Sep 24, 2015

Member

updating the documentation now.

Member

RaananW commented Sep 24, 2015

updating the documentation now.

@deltakosh

This comment has been minimized.

Show comment
Hide comment
@deltakosh

deltakosh Sep 24, 2015

Contributor

Lol this is fast:) thank you!

Contributor

deltakosh commented Sep 24, 2015

Lol this is fast:) thank you!

@RaananW

This comment has been minimized.

Show comment
Hide comment
@RaananW

RaananW Sep 24, 2015

Member

I'm only fast when I am sitting in front of my computer 😄

Member

RaananW commented Sep 24, 2015

I'm only fast when I am sitting in front of my computer 😄

@deltakosh

This comment has been minimized.

Show comment
Hide comment
@deltakosh

deltakosh Sep 24, 2015

Contributor

I hope so :D

Contributor

deltakosh commented Sep 24, 2015

I hope so :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment