New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing possible error with screenshot #701

Merged
merged 4 commits into from Sep 24, 2015

Conversation

Projects
None yet
2 participants
@RaananW
Member

RaananW commented Sep 24, 2015

There is a possibility, that when a user has two cameras and delivers the wrong size variable, the active camera will be replaced and never set back.

Replacing the cameras moved to a position after a return statement in case of an error.

RaananW added some commits Sep 23, 2015

Fixing possible error with screenshot
There is a possibility, that when a user has two cameras and delivers
the wrong size variable, the active camera will be replaced and never
set back.

deltakosh added a commit that referenced this pull request Sep 24, 2015

Merge pull request #701 from RaananW/screenshortBugFix
Fixing possible error with screenshot

@deltakosh deltakosh merged commit cdc9fce into BabylonJS:master Sep 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RaananW RaananW deleted the RaananW:screenshortBugFix branch Sep 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment