New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from collision cache #711

Merged
merged 2 commits into from Sep 29, 2015

Conversation

Projects
None yet
2 participants
@RaananW
Member

RaananW commented Sep 29, 2015

The remove function was missing, meshes and geometries would not have
been removed from the collision cache of the worker.

Remove from collision cache
The remove function was missing, meshes and geometries would not have
been removed from the collision cache of the worker.

@RaananW RaananW closed this Sep 29, 2015

@RaananW RaananW reopened this Sep 29, 2015

RaananW added a commit that referenced this pull request Sep 29, 2015

@RaananW RaananW merged commit 6a48c36 into BabylonJS:master Sep 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RaananW RaananW deleted the RaananW:remove-mesh-in-worker branch Sep 29, 2015

}
}
payload.removedGeometries.forEach(function (id) {
this._collisionCache.removeGeometry(id);

This comment has been minimized.

@deltakosh

deltakosh Sep 29, 2015

Contributor

this "this" looks suspicious to me

@deltakosh

deltakosh Sep 29, 2015

Contributor

this "this" looks suspicious to me

This comment has been minimized.

@RaananW

RaananW Sep 29, 2015

Member

Ah!... Yes, it is ☺. Tested with a for loop and changed to forEach.
Fixed soon.

@RaananW

RaananW Sep 29, 2015

Member

Ah!... Yes, it is ☺. Tested with a for loop and changed to forEach.
Fixed soon.

@RaananW RaananW referenced this pull request Sep 29, 2015

Merged

Fix for wrong "this" #715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment