Physics api changes and Oimo fixes #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Scene's "enablePhysics" does not require the gravity, there is a default value at the setGravity function of the physics engine.
Oimo plugin was restructured to use quaternion (no euler rotations of the mesh will be used). getWorldObject was added for low-level world manipulations (if needed by the developer).
Oimo has a bug in its body class (which I doubt will ever be fixed). Rotation cannot be used correctly while creating a compound object. Setting the rotation afterwards works correctly.
For those who wish to execute low-level physics changes to the mesh's physics body - the physics engine now exposes a function that will return it.
|
Wait with merging, further changes coming. |
making sure the bounding box is calculated correctly.
|
All should be fine now. |
deltakosh
added a commit
that referenced
this pull request
Oct 19, 2015
Physics api changes and Oimo fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new functions were added to the physics engine (for low-level manipulations):
Oimo now uses Quaternion rotation only, and initialized rotations correctly. It is also partly restructured.
Small bug fix for Cannon.js plugin that will appear if the mesh's center of mass is not in the middle.
Scene's enable physics function - gravity is optional. It will be set to the default if the function will be executed with no parameters at all.
All tested with the Gravity scene from the samples.