New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babylon.sceneSerializer.ts #830

Merged
merged 1 commit into from Nov 19, 2015

Conversation

Projects
None yet
4 participants
@dad72
Contributor

dad72 commented Nov 18, 2015

added collisionsEnabled and workerCollisions for serialization

Update babylon.sceneSerializer.ts
add collisionsEnabled and workerCollisions
@dad72

This comment has been minimized.

Show comment
Hide comment
@dad72

dad72 Nov 19, 2015

Contributor

There is a problem with this PR ? Why does it not confirm with others that have been? I make mistakes on one of its two line?
serializationObject.collisionsEnabled = scene.collisionsEnabled;
serializationObject.workerCollisions = scene.workerCollisions;

Contributor

dad72 commented Nov 19, 2015

There is a problem with this PR ? Why does it not confirm with others that have been? I make mistakes on one of its two line?
serializationObject.collisionsEnabled = scene.collisionsEnabled;
serializationObject.workerCollisions = scene.workerCollisions;

@Temechon

This comment has been minimized.

Show comment
Hide comment
@Temechon

Temechon Nov 19, 2015

Contributor

Raanan is the collision master, I think it's up to him to validate your PR. For me it seems ok (only two lines), but maybe there are some edge effects.
Just wait his feedback :)

Contributor

Temechon commented Nov 19, 2015

Raanan is the collision master, I think it's up to him to validate your PR. For me it seems ok (only two lines), but maybe there are some edge effects.
Just wait his feedback :)

@RaananW

This comment has been minimized.

Show comment
Hide comment
@RaananW

RaananW Nov 19, 2015

Member

Hi, sorry, I just waved to wait with it until I finish the scene loader as well. Merging won't matter, as it's not read yet.
I'll merge now and hopefully commit my changes in a few hours

Member

RaananW commented Nov 19, 2015

Hi, sorry, I just waved to wait with it until I finish the scene loader as well. Merging won't matter, as it's not read yet.
I'll merge now and hopefully commit my changes in a few hours

@RaananW

This comment has been minimized.

Show comment
Hide comment
@RaananW

RaananW Nov 19, 2015

Member

(*just wanted)

Member

RaananW commented Nov 19, 2015

(*just wanted)

RaananW added a commit that referenced this pull request Nov 19, 2015

Merge pull request #830 from dad72/patch-7
Update babylon.sceneSerializer.ts

@RaananW RaananW merged commit df33ba7 into BabylonJS:master Nov 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dad72

This comment has been minimized.

Show comment
Hide comment
@dad72

dad72 Nov 19, 2015

Contributor

Ok.

Contributor

dad72 commented Nov 19, 2015

Ok.

@deltakosh

This comment has been minimized.

Show comment
Hide comment
@deltakosh

deltakosh Nov 19, 2015

Contributor

And please do not forget to update this as well: http://doc.babylonjs.com/generals/File_Format_Map_(.babylon)

Contributor

deltakosh commented Nov 19, 2015

And please do not forget to update this as well: http://doc.babylonjs.com/generals/File_Format_Map_(.babylon)

@RaananW

This comment has been minimized.

Show comment
Hide comment
@RaananW

RaananW Nov 19, 2015

Member

working on it now, I just added a few more properties.

Member

RaananW commented Nov 19, 2015

working on it now, I just added a few more properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment