Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show skeleton viewer if isEnabled=false #8406

Merged
merged 3 commits into from Jun 18, 2020
Merged

Don't show skeleton viewer if isEnabled=false #8406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51cb119
Fix crash when loading vertex colors from a .obj file
Popov72 Jun 17, 2020
2ab1140
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
Popov72 Jun 18, 2020
8df94a3
Don't show the skeleton viewer if isEnabled=false
Popov72 Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions dist/preview release/what's new.md
View file
Open in desktop
Expand Up @@ -233,6 +233,7 @@
- Fixed `AssetContainer.instantiateModelsToScene` with cloneMaterials=true and MultiMaterials to properly set the cloned submaterials ([ghempton](https://github.com/ghempton))
- Fixed wrong display when setting `DefaultRenderingPipeline.imageProcessingEnabled` to `false` ([Popov72](https://github.com/Popov72))
- Fix crash when loading a .obj file with vertex colors ([Popov72](https://github.com/Popov72))
- Fix skeleton viewer still visible when `isEnabled = false` ([Popov72](https://github.com/Popov72))

## Breaking changes

Expand Down
4 changes: 4 additions & 0 deletions src/Debug/skeletonViewer.ts
View file
Open in desktop
Expand Up @@ -70,6 +70,10 @@ export class SkeletonViewer {

this._isEnabled = value;

if (this._debugMesh) {
this._debugMesh.setEnabled(value);
}

if (value) {
this._scene.registerBeforeRender(this._renderFunction);
} else {
Expand Down