Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration files for Ponicode tests #9773

Merged
merged 3 commits into from Jan 19, 2021
Merged

Conversation

sguillia
Copy link
Contributor

@sguillia sguillia commented Jan 11, 2021

Hi!

This pull request adds configuration files for Ponicode.

Here are instructions to get started
https://drive.google.com/file/d/1T6lOF-fxHn860pjmDFe398z3l3bulqRr/view?usp=sharing

Best,
The Ponicode team

@@ -3,6 +3,8 @@
"compilerOptions": {
"types": [],
"baseUrl": "./",
"rootDir": "./"
"rootDir": "./",
"outDir": "../.temp/manualBuildCore",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebavan : can this be a problem? (To define an outdir?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sguillia Did you try to compile the project with npm run build to ensure your changes are not breaking the build?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup all good :-)

@sebavan
Copy link
Member

sebavan commented Jan 11, 2021

at worst @sguillia force it in your gulp task

@sguillia sguillia marked this pull request as draft January 12, 2021 14:36
@RaananW RaananW marked this pull request as ready for review January 19, 2021 11:11
@RaananW RaananW merged commit 0a8c4c7 into BabylonJS:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants