Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of mipmaps creation for some texture formats #1392

Closed
CedricGuillemet opened this issue Jun 12, 2024 · 2 comments
Closed
Milestone

Comments

@CedricGuillemet
Copy link
Contributor

Related : #1391

For some texture formats are converted to RGBA8 or RGBA32F before computing mipmaps because of bgfx limitations. Add support for most(all?) texture formats.

see

if (image->m_format == bimg::TextureFormat::RGB8)

@thomlucc thomlucc added this to the 8.0 milestone Jun 12, 2024
CedricGuillemet added a commit that referenced this issue Jun 24, 2024
Temporary fix for a user until this is done and replaces this change:
#1392
@bghgary
Copy link
Contributor

bghgary commented Sep 5, 2024

No one has asked for this, we noticed this while adding some formats. We can improve memory usage and possibly CPU cost if we do this work.

@bghgary
Copy link
Contributor

bghgary commented Sep 13, 2024

Closing for now. Reopen if we want to fix this.

@bghgary bghgary closed this as completed Sep 13, 2024
@bghgary bghgary reopened this Sep 13, 2024
@bghgary bghgary closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants